New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smithy-cli as project dependency when plugin used within smithy #151

Open

haydenbaker wants to merge 1 commit into main from haydenbaker/update-cli-resolution

Contributor

haydenbaker commented Feb 6, 2025

Background

As discovered in Exclude smithy-cli from being included by validation model smithy-java#583, enforcing projects in the smithy repository to explicitly depend on the CLI has the unintended consequence of bringing it into the runtime classpath
This change makes it so that the plugin will automatically add the cli as a project dependency if the plugin is used within a main smithy project

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


          Use smithy-cli as project dependency when plugin used within smithy r…

d9916e8

…epository

haydenbaker requested a review from a team as a code owner

February 6, 2025 22:42

haydenbaker requested a review from hpmellema

February 6, 2025 22:42

hpmellema approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet