Remove AuthProperties and just use Context #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than essentially recreate Context for Auth and Identity related properties, we can just use Context. AuthProperties already used Context.Key, but recreated most of Context in order to be immutable. This isn't strictly necessary given Context can be made immutable using Context.unmodifiableView(ctx). In order to make this change, we needed to add a few missing methods to Context that are good additions: merge (merge two contexts and return a new context), getOrDefault, and Context.empty (return an immutable and empty context).
adwsingh
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than essentially recreate Context for Auth and Identity related properties, we can just use Context. AuthProperties already used Context.Key, but recreated most of Context in order to be immutable. This isn't strictly necessary given Context can be made immutable using Context.unmodifiableView(ctx).
In order to make this change, we needed to add a few missing methods to Context that are good additions: merge (merge two contexts and return a new context), getOrDefault, and Context.empty (return an immutable and empty context).
This is just @mtdowling's change rebased onto
main. I need access to the full request Context to write request-scoped identity resolvers.