Add runtime plugin for generating stand-alone images #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenbaker
force-pushed
the
haydebak/add-runtime-plugin
branch
from
c24468a to
0c3374d
Compare
haydenbaker
changed the title
Updates the runtime plugin to a fork with support for java 21, instead of the upstream https://github.com/beryx/badass-runtime-plugin. See beryx/badass-runtime-plugin#154 for more details. Also changed the java version back to 21.
milesziemer
force-pushed
the
haydebak/add-runtime-plugin
branch
from
0c3374d to
62393b5
Compare
|
Moving out of draft. Will use fork of the runtime plugin until upstream gets java 21 support added. See 62393b5. |
We had a github workflow that would run on a tag push, creating a new release and uploading a zip of the language server. Jreleaser should take care of all that now, so the workflow is unnecessary.
So we don't have to manually add the release notes to the github release after it is published. I added a custom task to read in the full changelog, and parse out the entry for the latest version. The result is written out to a resources file that I pointed the github release config to. The jreleaser docs don't seem to be 100% clear on whether the changelog is actually what ends up in the release notes, but it would make sense to me, and the text in https://jreleaser.org/guide/latest/reference/release/github.html#_release_notes suggests it.
milesziemer
force-pushed
the
haydebak/add-runtime-plugin
branch
from
81e98a8 to
9479b25
Compare
milesziemer
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft until beryx/badass-runtime-plugin#153 is resolved (and jdk21 is supported)
Description of changes:
./gradlew runtime)./build/image/smithy-language-server-darwin-aarch64/bin/smithy-language-server 0By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.