Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved initializeParams to serverOptions class #185

Merged
merged 7 commits into from
Jan 17, 2025
Merged

moved initializeParams to serverOptions class #185

merged 7 commits into from
Jan 17, 2025

Conversation

divmeh-aws
Copy link
Contributor

Issue #, if available:

#171
Bullet point 1 of the issue is addressed here.

Description of changes:

  • New class ServerOptions validates and saves config options sent by the client. This makes it neatly extensible when we add new options down the line.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@divmeh-aws divmeh-aws requested a review from a team as a code owner January 14, 2025 22:21
@divmeh-aws divmeh-aws requested a review from hpmellema January 14, 2025 22:21
@milesziemer milesziemer requested review from milesziemer and removed request for hpmellema January 16, 2025 16:43
divmeh-aws
divmeh-aws commented Jan 17, 2025
View reviewed changes
Copy link
Contributor Author

@divmeh-aws divmeh-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed requested changes.

@milesziemer milesziemer merged commit 224bc64 into main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesziemer milesziemer milesziemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divmeh-aws @milesziemer