Cleanup serverstate and project #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesziemer
requested review from
JordonPhillips and
yefrig
and removed request for
JordonPhillips
yefrig
approved these changes
Jan 17, 2025
| /** | ||
| * Provides access to {@link Document}s managed by the server. | ||
| * | ||
| * <p>A document is _managed_ if its state is controlled by the lifecycle methods |
There was a problem hiding this comment.
nit: if
is a separator then maybe keep it on its own line
When loading a project, SmithyFiles were being read from disk multiple times. This commit refactors ProjectLoader to only read from disk once, and also cleans up some stuff.
Project loading can now depend on a single interface that provides access to managed files, rather than ServerState itself.
milesziemer
force-pushed
the
cleanup-serverstate
branch
from
400dfa7 to
3927e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various refactoring commits that clean up ServerState and Project. Exposing the fields of ServerState made it super annoying to refactor, so I made ServerState a class and hid everything. Then, I was able to make ServerState only store one collection of projects, and handle its own mutations. Similar story for Project.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.