Expand tests on parser to acheive higher coverage and minor fixs #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… branch, Add fix for Node with leading comma, Add fix for duplicate statement when invalid member def statement appears, Add fix for unset end of kvp.
joewyz
commented
Mar 12, 2025
milesziemer
requested changes
Apr 2, 2025
src/test/java/software/amazon/smithy/lsp/syntax/IdlParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/smithy/lsp/syntax/NodeParserTest.java
Outdated
Show resolved
Hide resolved
milesziemer
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Expand tests on parser to acheive a coverage of 98% in Line and 88% in branch.
Add fix for Node with leading comma.
Add fix for duplicate statement when invalid member def statement appears.
Add fix for unset end of kvp.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.