Cleanup build script #222
Merged
Cleanup build script #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the VERSION file, so this plugin should be unnecessary.
milesziemer
requested review from
yasmewad and
joewyz
and removed request for
yasmewad
The dependency declaration for smithy libraries wasn't using string interpolation, so the version was literally "[smithyVersion, 2.0[". Maybe it was just a thing you could do in groovy, otherwise it's been like that since 2023.
joewyz
approved these changes
Apr 16, 2025
haydenbaker
reviewed
Apr 17, 2025
Comment on lines
+54
to
+57
| implementation("software.amazon.smithy:smithy-build:[$smithyVersion, 2.0[") | ||
| implementation("software.amazon.smithy:smithy-cli:[$smithyVersion, 2.0[") | ||
| implementation("software.amazon.smithy:smithy-model:[$smithyVersion, 2.0[") | ||
| implementation("software.amazon.smithy:smithy-syntax:[$smithyVersion, 2.0[") |
There was a problem hiding this comment.
You don't really need to set the version if you're using a range, just [1.0, 2.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build script was a mess and it has been bugging me for a while, so I'm
finally cleaning it up. I mostly reorganized things, and removed unnecessary
configuration, but there are some minor changes to note:
use the VERSION file to manage the project version.
it to was already the default.
stdout/err, which should reduce some noise.
string interpolation, so were literally "[smithyVersion, 2.0[". Either that was
a thing you could do in groovy, or it's been busted since 2023. Yikes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.