Skip to content

RFC: Server Request Metrics#4458

Merged
rcoh merged 1 commit into
mainfrom
rfc0046_server_request_metrics
Feb 12, 2026
Merged

RFC: Server Request Metrics#4458
rcoh merged 1 commit into
mainfrom
rfc0046_server_request_metrics

Conversation

@jasgin
Copy link
Copy Markdown
Contributor

@jasgin jasgin commented Dec 22, 2025 •
edited
Loading

Motivation and Context

Description

See rendered preview

Testing

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jasgin jasgin requested review from a team as code owners December 22, 2025 00:46
@github-actions

This comment was marked as outdated.

Sign in to view
rcoh
rcoh approved these changes Dec 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good.

The RFC could definitely be fleshed out a bit more — I don't totally get how it will work with operation specific metrics etc.

Comment thread design/src/rfcs/rfc0046_server_request_metrics.md
Comment thread design/src/rfcs/rfc0046_server_request_metrics.md Outdated
Comment thread design/src/rfcs/rfc0046_server_request_metrics.md Outdated
Comment thread design/src/rfcs/rfc0046_server_request_metrics.md Outdated
Comment thread design/src/rfcs/rfc0046_server_request_metrics.md
Comment thread design/src/rfcs/rfc0046_server_request_metrics.md Outdated
@aajtodd
Copy link
Copy Markdown
Contributor

aajtodd commented Jan 5, 2026

This seems specific to metrique, was there not consideration given to our own runtime observability API: https://github.com/smithy-lang/smithy-rs/tree/main/rust-runtime/aws-smithy-observability

@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 5ebaf8b to 860daae Compare January 9, 2026 15:27
@jasgin
Copy link
Copy Markdown
Contributor Author

jasgin commented Jan 9, 2026

Added some more content to the RFC explaining some of the open questions, and added a preliminary implementation of the metrics layer interface.

Yes the design only has metrique in mind. Maybe future scope can extend to aws-smithy-observability as well.

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch 4 times, most recently from 0b97c30 to 5654ba7 Compare January 11, 2026 21:10
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 3c5802d to c506136 Compare January 12, 2026 00:59
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from ba8bcac to a6c26fb Compare January 12, 2026 04:24
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from b6a1b9b to 1fdb9fe Compare January 12, 2026 14:02
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from d8b1a6c to 2ca03d6 Compare January 13, 2026 17:48
@github-actions

This comment was marked as outdated.

Sign in to view
rcoh
rcoh reviewed Jan 13, 2026
View reviewed changes
Comment thread design/src/rfcs/rfc0046_server_request_metrics.md Outdated
Comment thread rust-runtime/aws-smithy-http-server-metrics-macro/Cargo.toml
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 2c5b5e0 to a12e067 Compare January 13, 2026 19:29
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 3ae882e to 7c00efd Compare January 13, 2026 21:20
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch 2 times, most recently from 9696581 to 88b6e2c Compare February 10, 2026 16:56
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch 2 times, most recently from 004350e to e98eb69 Compare February 10, 2026 17:50
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch 2 times, most recently from 2052f8d to 8a296f0 Compare February 10, 2026 19:41
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin
Copy link
Copy Markdown
Contributor Author

jasgin commented Feb 10, 2026

@aajtodd Just wanted to provide some more thoughts regarding the question pertaining to aws-smithy-observability. This work was also specifically scoped for metrics in terms of unit-of-work measurements as opposed to point-in-time and unit-of-time. I think there is probably another conversation that should be had for the latter that may point towards an integration with aws-smithy-observability.

drganjoo
drganjoo reviewed Feb 11, 2026
View reviewed changes
Comment thread examples/pokemon-service-common/src/lib.rs Outdated
Comment thread examples/pokemon-service-common/src/lib.rs Outdated
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 4108911 to c0c1823 Compare February 11, 2026 12:30
@github-actions

This comment was marked as outdated.

Sign in to view
@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from c0c1823 to 9c5b7c1 Compare February 11, 2026 13:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

A new generated diff is ready to view.

A new doc preview is ready to view.

@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 9c5b7c1 to 24627da Compare February 11, 2026 13:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

A new generated diff is ready to view.

A new doc preview is ready to view.

@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 24627da to 4d0128d Compare February 11, 2026 14:15
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 11, 2026

A new generated diff is ready to view.

A new doc preview is ready to view.

@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch 3 times, most recently from 2573027 to 6d11a2a Compare February 12, 2026 15:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 12, 2026

A new generated diff is ready to view.

A new doc preview is ready to view.

@jasgin jasgin force-pushed the rfc0046_server_request_metrics branch from 6d11a2a to db82636 Compare February 12, 2026 16:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 12, 2026

A new generated diff is ready to view.

A new doc preview is ready to view.

@rcoh rcoh merged commit cc7ab30 into main Feb 12, 2026
50 checks passed
@rcoh rcoh deleted the rfc0046_server_request_metrics branch February 12, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcoh rcoh rcoh approved these changes

@drganjoo drganjoo drganjoo left review comments

@landonxjames landonxjames landonxjames approved these changes

@jlizen jlizen jlizen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasgin @aajtodd @rcoh @landonxjames @drganjoo @jlizen