Add full support for AWS chunked content encoding#4504
Merged
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
approved these changes
Jan 29, 2026
Collaborator
landonxjames
left a comment
There was a problem hiding this comment.
LGTM! One question about an edge case with user-set chunk sizes and some other small notes, nothing blocking.
This commit addresses #4504 (comment)
This commit addresses #4504 (comment)
This commit addresses #4504 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
reviewed
Feb 2, 2026
This commit addresses #4504 (comment)
This commit addresses #4504 (comment)
This commit addresses #4504 (comment)
This commit addresses #4504 (comment)
This commit addresses #4504 (comment)
This commit addresses #4504 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
Feb 5, 2026
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1798
#4188
Description
This PR adds full support for AWS chunked content encoding, addressing limitations documented in these comments.
Customer impact
This PR affects S3's
PutObjectandUploadPartoperations with streaming payloads, changing their default behavior:Before: Streaming payloads were sent as a single chunk.
After: Streaming payloads are split into 64 KiB (the last chunk may be smaller) and sent in multiple chunks.
Customers who prefer the previous single-chunk behavior can disable chunking via the service config:
or specify a custom chunk size
Chunk signing
While this PR provides chunk signing capability, it only activates for non-TLS requests. For the majority of use cases where TLS provides encryption, streaming payloads continue to be sent unsigned with
x-amz-content-sha256set toSTREAMING-UNSIGNED-PAYLOAD-TRAILER.Implementation overview
The PR implements three key components:
AwsChunkedBodySimilar to event stream signing, chunk signing occurs after the initial HTTP request signing (sign_http_request) and requires context from that process. The deferred signer enables chunk signing to be wired up later as streaming bodies are yielded.
Testing
int_log16; it had a bug for the input value 0 (should return 1 but had returned 0)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.