Expand client metrics coverage by vcjana · Pull Request #4661 · smithy-lang/smithy-rs

vcjana · 2026-05-11T23:12:00Z

Addresses #4248. Adds 7 new metrics to MetricsInterceptor

call.attempts
call.errors
serialization_duration
deserialization_duration
auth.signing_duration
auth.resolve_identity_duration
resolve_endpoint_duration.

Identity/endpoint resolution timed in the orchestrator (no interceptor hooks for these phases), stored in ConfigBag.

Testing

Ran DDB PutItem benchmark with TelemetryProvider configured. the output confirms all 7 metrics are captured end-to-end

"sdkMetrics": {
 "callDurationMeanMs": 8.02,
 "attemptDurationMeanMs": 7.95,
 "serializationDurationMeanMs": 0.018,
 "deserializationDurationMeanMs": 0.027,
 "signingDurationMeanMs": 0.072,
 "resolveIdentityDurationMeanMs": 0.007,
 "resolveEndpointDurationMeanMs": 0.011,
 "totalAttempts": 36,
 "totalErrors": 1
}

Add 7 new metrics to MetricsInterceptor: - smithy.client.call.attempts (counter) - smithy.client.call.errors (counter) - smithy.client.call.serialization_duration (histogram) - smithy.client.call.deserialization_duration (histogram) - smithy.client.call.auth.signing_duration (histogram) - smithy.client.call.auth.resolve_identity_duration (histogram) - smithy.client.call.resolve_endpoint_duration (histogram) Identity and endpoint resolution durations are measured in the orchestrator and stored in the ConfigBag for the interceptor to record.

aajtodd

Some questions/thoughts that don't necessarily have to be resolved in this PR.

We should ensure we do a comprehensive review and update of our observability documentation in the dev guide as part of this. #4503
We should define and integrate a new telemetry provider based on metrique: #4502
Have we given any additional thought to unit of work (per request metrics rather than only aggregate we have now): #4499

github-actions · 2026-05-13T18:18:05Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

vcjana force-pushed the expand-client-metrics branch from e70cd0e to 0414085 Compare May 11, 2026 23:25

Guard orchestrator timing behind OperationTelemetry check

e3e38b6

vcjana force-pushed the expand-client-metrics branch from 0414085 to e3e38b6 Compare May 11, 2026 23:26