Allow developers to bind aws_smithy_mocks::RuleBuilder to a variable - #4665
Open
eagletmt wants to merge 3 commits into
Open
Allow developers to bind aws_smithy_mocks::RuleBuilder to a variable#4665eagletmt wants to merge 3 commits into
eagletmt wants to merge 3 commits into
Conversation
Currently, the following code does not compile because it requires an experimental feature. rust-lang/rust#15701 ```rust let rule_builder = aws_smithy_mocks::mock!(aws_sdk_s3::Client::get_object); ``` Developers can workaround this issue by surrounding it with braces. ```rust let rule_builder = { aws_smithy_mocks::mock!(aws_sdk_s3::Client::get_object) }; ``` This PR adds the workaround to the aws-smithy-mocks crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, the following code does not compile because it requires an experimental feature.
rust-lang/rust#15701
I'd like to allow this style.
Description
We can workaround this issue by surrounding it with braces.
This PR adds the workaround to the aws-smithy-mocks crate.
Testing
I added test cases.
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.