Fixing issue with credential_process on windows - #4784
Draft
landonxjames wants to merge 4 commits into
Draft
Conversation
It would fail to resolve credentials if the path contained a space
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
1 similar comment
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
1 similar comment
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Internal customer reported that
credential_processwould fail on windows if the path contained a space. That wasn't caught because we disabled most of thecredential_processtests on Windows (due to them using unix style paths). Fixed that with raw_arg, but still wasn't able to test it in CI.Testing
This is the larger part of this PR. Created a standalone CI task
test-rust-windows-aws-config. It runs theaws-configtests with a minimal set of featurescargo test --no-default-features --features "credentials-process,rt-tokio"to get around issues withaws-lcon Windows.#4755 added a new feature to
aws-configdoubling the amount of tests run bycargo hack. That was timing out sometimes so this PR also increases the timeout for that test.Checklist
.changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.