fix(server): move AlbHealthCheckLayer to A-position in pokemon-service example - #4788
Open
sachinsharma3191 wants to merge 1 commit into
Open
fix(server): move AlbHealthCheckLayer to A-position in pokemon-service example#4788sachinsharma3191 wants to merge 1 commit into
sachinsharma3191 wants to merge 1 commit into
Conversation
…e example The AlbHealthCheckLayer was registered in B-position (inside PokemonServiceConfig) on `/ping`, but the modeled `CheckHealth` operation already owns that route. The health check handler was therefore never reached. Move the layer to A-position (wrapping the router) and change the path to `/health` so it does not collide with the modeled operation. This correctly answers health checks before routing. Fixes smithy-rs#4631, smithy-rs#3607, smithy-rs#3606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlbHealthCheckLayerwas registered in B-position (insidePokemonServiceConfig::builder()) on/ping, but the modeledCheckHealthoperation already owns that route. The health check handler was never reached.metrics_layer) and changed the path to/healthso it does not collide with the modeled operation./healthinstead of/ping.Fixes #4631, #3607, #3606
Test plan
health_checkintegration test inexamples/pokemon-service/tests/simple.rsto use/healthcargo build -p pokemon-servicecompilescargo test -p pokemon-service --test simplepasses the health check test