Do not default endpoint with stub responses (#331)

Author: mullermp

gems/smithy-client/spec/smithy-client/log_formatter_spec.rb

@@ -6,7 +6,7 @@ module Smithy
   module Client
     describe LogFormatter do
       let(:client_class) { ClientHelper.sample_client.const_get(:Client) }
-      let(:client) { client_class.new(stub_responses: true) }
+      let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
       let(:response) { client.operation }
 
       def formatted(pattern, options = {})

gems/smithy-client/spec/smithy-client/plugins/checksum_required_spec.rb

@@ -9,7 +9,7 @@ module Plugins
         let(:shapes) { ClientHelper.sample_shapes }
         let(:sample_client) { ClientHelper.sample_client(shapes: shapes) }
         let(:client_class) { sample_client.const_get(:Client) }
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         before do
           shapes['smithy.ruby.tests#Operation']['traits'] = { 'smithy.api#httpChecksumRequired' => {} }

gems/smithy-client/spec/smithy-client/plugins/default_params_spec.rb

@@ -8,7 +8,7 @@ module Plugins
       describe ParamValidator do
         let(:sample_client) { ClientHelper.sample_client }
         let(:client_class) { sample_client.const_get(:Client) }
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         it 'adds the handler' do
           expect(client.handlers).to include(DefaultParams::Handler)

gems/smithy-client/spec/smithy-client/plugins/http_api_key_auth_spec.rb

@@ -15,7 +15,7 @@ module Plugins
           client_class
         end
 
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         before do
           shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpApiKeyAuth'] = {}

gems/smithy-client/spec/smithy-client/plugins/http_basic_auth_spec.rb

@@ -15,7 +15,7 @@ module Plugins
           client_class
         end
 
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         before do
           shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpBasicAuth'] = {}

gems/smithy-client/spec/smithy-client/plugins/http_bearer_auth_spec.rb

@@ -15,7 +15,7 @@ module Plugins
           client_class
         end
 
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         before do
           shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpBearerAuth'] = {}

gems/smithy-client/spec/smithy-client/plugins/http_digest_auth_spec.rb

@@ -15,7 +15,7 @@ module Plugins
           client_class
         end
 
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         before do
           shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpDigestAuth'] = {}

gems/smithy-client/spec/smithy-client/plugins/idempotency_token_spec.rb

@@ -9,7 +9,7 @@ module Plugins
         let(:shapes) { ClientHelper.sample_shapes }
         let(:sample_client) { ClientHelper.sample_client(shapes: shapes) }
         let(:client_class) { sample_client.const_get(:Client) }
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         before do
           shapes['smithy.ruby.tests#Structure']['members']['string'] = {

gems/smithy-client/spec/smithy-client/plugins/logging_spec.rb

@@ -8,7 +8,8 @@ module Plugins
       describe Logging do
         let(:sample_client) { ClientHelper.sample_client }
         let(:client_class) { sample_client.const_get(:Client) }
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client_options) { { stub_responses: true, endpoint: 'https://example.com' } }
+        let(:client) { client_class.new(client_options) }
 
         let(:logger) { Logger.new(IO::NULL) }
         let(:log_level) { :info }
@@ -30,24 +31,24 @@ module Plugins
         end
 
         it 'adds the handler when a logger is provided' do
-          client = client_class.new(stub_responses: true, logger: logger)
+          client = client_class.new(client_options.merge(logger: logger))
           expect(client.handlers).to include(Logging::Handler)
         end
 
         it 'logs the output to the log level' do
-          client = client_class.new(stub_responses: true, logger: logger)
+          client = client_class.new(client_options.merge(logger: logger))
           expect(logger).to receive(client.config.log_level).with(instance_of(String))
           client.operation
         end
 
         it 'logs the output using the log formatter' do
-          client = client_class.new(stub_responses: true, logger: logger)
+          client = client_class.new(client_options.merge(logger: logger))
           expect(client.config.log_formatter).to receive(:format).with(instance_of(Response))
           client.operation
         end
 
         it 'sets start and end times in the context' do
-          client = client_class.new(stub_responses: true, logger: logger, log_level: log_level)
+          client = client_class.new(client_options.merge(logger: logger, log_level: log_level))
           response = client.operation
           expect(response.context[:logging_started_at]).to be_kind_of(Time)
           expect(response.context[:logging_completed_at]).to be_kind_of(Time)

gems/smithy-client/spec/smithy-client/plugins/pageable_response_spec.rb

@@ -55,7 +55,7 @@ module Plugins
 
         let(:sample_client) { ClientHelper.sample_client(shapes: shapes) }
         let(:client_class) { sample_client.const_get(:Client) }
-        let(:client) { client_class.new(stub_responses: true) }
+        let(:client) { client_class.new(stub_responses: true, endpoint: 'https://example.com') }
 
         context 'pagination' do
           it 'can paginate with next_page and next_page?' do