Improve testing of client features#290
Merged
Merged
Conversation
mullermp
changed the title
jterapin
approved these changes
Apr 11, 2025
Contributor
jterapin
left a comment
jterapin
left a comment
There was a problem hiding this comment.
Just need to fix the rbs failures + some partially eaten test that I commented on.
Comment on lines
+85
to
+86
| it 'signs in the header' | ||
| end |
Contributor
There was a problem hiding this comment.
Missing part of a test here?
Contributor
Author
There was a problem hiding this comment.
It's pending implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra protocol plugin tests and pushes stub response tests to client where it can use a default protocol, and pushes auth tests to the client.