Waiters#292
Merged
Merged
Conversation
richardwang1124
commented
May 1, 2025
richardwang1124
commented
May 1, 2025
richardwang1124
commented
May 1, 2025
richardwang1124
commented
May 1, 2025
richardwang1124
commented
May 1, 2025
richardwang1124
commented
May 1, 2025
| end | ||
| expect_any_instance_of(waiter).to receive(:delay).and_wrap_original do |m, *args| | ||
| delay = m.call(*args) | ||
| expect(delay).to equal(5) |
Contributor
Author
There was a problem hiding this comment.
This test case is an example of the question I had in my doc regarding waiter retries. Because the remaining time (5) minus the delay (value between min delay of 3 and max delay of 4) is less than the min delay, the final delay value is set to be equal to the remaining time, which is 5. However, this exceeds the max delay. Is this expected behavior?
mullermp
reviewed
May 1, 2025
jterapin
reviewed
May 6, 2025
Contributor
jterapin
left a comment
jterapin
left a comment
There was a problem hiding this comment.
Nice! Great work so far - mini-review since you are working through changes and etc.
mullermp
reviewed
May 11, 2025
Contributor
mullermp
left a comment
mullermp
left a comment
There was a problem hiding this comment.
Nice! Getting better. Sorry for the barrage of comments.
mullermp
reviewed
May 21, 2025
Contributor
mullermp
left a comment
mullermp
left a comment
There was a problem hiding this comment.
Nice! Clean ups are looking good. This should be very close.
| # @api private | ||
| module Waiters | ||
| <% waiters.each do |waiter| -%> | ||
| <% if waiter.deprecated -%> |
Contributor
There was a problem hiding this comment.
Up to you - you can always have a method deprecated? instead of attribute accessor deprecated - since you never actually need to retrieve any nested value of deprecated, it's simply a boolean. That's more conventional.
| @@ -0,0 +1,38 @@ | |||
| $version: "2" | |||
Contributor
There was a problem hiding this comment.
nit - name of folder waiters
mullermp
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Support the
#waitabletrait with waiters. Customers can use code generated waiters throughclient.wait_until(:waiter_name, params, options).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.