Conversation
jterapin
approved these changes
Apr 29, 2025
| def union(shape, values, target = nil) | ||
| # TODO: delete target instead of checking key? | ||
| def union(shape, values, target = nil) # rubocop:disable Metrics/AbcSize | ||
| raise ArgumentError, "union value includes more than one key, received: #{values.keys}" if values.size > 1 |
Contributor
There was a problem hiding this comment.
So we would want to raise than using the first key/value that we encounter? (I think using the first key/value was the V3 behavior if I remember correctly)
Contributor
Author
There was a problem hiding this comment.
I'm not sure here. Kevin seems to suggest we should raise. I think using the first might be preferred, but then we have to code around __type which I can't seem to find any details for in cbor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted some TODOs or addressed them.