Feature ids#312
Merged
Merged
Conversation
richardwang1124
commented
Jul 11, 2025
mullermp
reviewed
Jul 11, 2025
mullermp
reviewed
Jul 15, 2025
mullermp
approved these changes
Jul 15, 2025
jterapin
approved these changes
Jul 16, 2025
Contributor
jterapin
left a comment
jterapin
left a comment
There was a problem hiding this comment.
Nice! Great job on this side quest
| def call(context) | ||
| build_request(context) | ||
| response = @handler.call(context) | ||
| response = Features.track('PROTOCOL_RPC_V2_CBOR') { @handler.call(context) } |
Contributor
There was a problem hiding this comment.
Friendly reminder that whenever we do the aws-variation of the plugin, we will need to bring this.
Contributor
There was a problem hiding this comment.
Good point - we can probably not bother tracking this here and delete it.
mullermp
approved these changes
Jul 16, 2025
| def call(context) | ||
| build_request(context) | ||
| response = @handler.call(context) | ||
| response = Features.track('PROTOCOL_RPC_V2_CBOR') { @handler.call(context) } |
Contributor
There was a problem hiding this comment.
Good point - we can probably not bother tracking this here and delete it.
| end | ||
|
|
||
| def track_feature(encoding, &block) | ||
| if encoding == 'gzip' |
Contributor
There was a problem hiding this comment.
case when would be appreciated here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add features module to capture generic feature ids.