Skip to content

Support vendor params in protocol tests#315

Merged
mullermp merged 5 commits into
decaffrom
vendor_params
Jul 17, 2025
Merged

Support vendor params in protocol tests#315
mullermp merged 5 commits into
decaffrom
vendor_params

Conversation

@mullermp
Copy link
Copy Markdown
Contributor

@mullermp mullermp commented Jul 16, 2025

Support vendor params hook in welds for protocol tests. These are needed for additional assertions.

Usage might be like:

      def protocol_test_vendor_code
        {
          'aws.protocoltests.config#ErrorCodeParams' => ErrorCodeParams.new
        }
      end

      # Used for generating error code expectations in protocol tests.
      class ErrorCodeParams
        def error_expect_code(params)
          <<~CODE
            expect(e.code).to eq('#{params['code']}')
            # except(e.type).to eq('#{params['type']}')
          CODE
        end
      end

Copy link
Copy Markdown
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mullermp mullermp merged commit 70b4af9 into decaf Jul 17, 2025
5 checks passed
@mullermp mullermp deleted the vendor_params branch July 17, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants