Conversation
Contributor
richardwang1124
left a comment
richardwang1124
left a comment
There was a problem hiding this comment.
Nice work, left a few questions. Most changes are very similar to V3.
| def consume_child_frame(child) # rubocop:disable Metrics/AbcSize | ||
| case child | ||
| when MapEntryFrame | ||
| @result[@member[:name]] ||= {} |
Contributor
There was a problem hiding this comment.
I noticed that the V3 code does not have this. Should we fix this in V3? Not sure how possible/likely that @result[@member[:name]] would be nil.
Contributor
Author
There was a problem hiding this comment.
In the v3 code we were using DefaultList and DefaultMap. I think this was wrong because even when there weren't any values, we would parse empty lists and maps. There is a patch in the json parser in v3 that has to maintain this behavior from query to json compatibility. I'm not 100% but this should have prevented this, I will double check.
jterapin
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Smithy XML gem for generic XML parsing. It has the same 5 engines as SDK v3. It currently passes AwsQuery protocol tests.