Add IdentityProvider#319
Merged
Merged
Conversation
mullermp
reviewed
Jul 30, 2025
| module Client | ||
| # This module provides basic accessors and methods for an | ||
| # Identity Resolver class which resolves an Identity. | ||
| module IdentityResolver |
Contributor
There was a problem hiding this comment.
You should include this in the existing identity providers in this package. (Also should this be called Identity Provider?)
Can you also add rbs for this and the other providers in here?
Contributor
Author
There was a problem hiding this comment.
I think strictly following SRA it would be IdentityResolver, but I think IdentityProvider is fine. Also the SRA uses IdentityProvider in places too, not very consistent.
mullermp
approved these changes
Jul 30, 2025
Contributor
mullermp
left a comment
mullermp
left a comment
There was a problem hiding this comment.
You can remove the _IdentityProvider interface too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IdentityProvider module.