Skip to content
Open
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
7ba5622
feat: add HttpHandler backed by Node.js undici
trivikr May 14, 2026
f6b592c
test: add validation for value provided for ms
trivikr May 14, 2026
3f15360
test: add benchmarks using vitest
trivikr May 14, 2026
86ed893
chore: yarn changeset
trivikr May 14, 2026
450e88b
test: use '127.0.0.1' instead of localhost
trivikr May 14, 2026
2b98884
chore: skip '.bench.ts' from check-dependencies
trivikr May 14, 2026
3d71928
test(undici-http-handler): compare with undici major version
trivikr May 14, 2026
6d0dfd4
test(undici-http-handler): revert compare with undici major version
trivikr May 14, 2026
9e6ef9e
chore(undici-http-handler): define 'undici' version in peerDependencies
trivikr May 14, 2026
ba0f0a4
fix: temporarily exclude undici-http-handler from types check
trivikr May 14, 2026
4ae1d6d
chore: switch to using private keyword
trivikr May 14, 2026
abdb661
test: use import in '.version.spec.ts'
trivikr May 14, 2026
1347a8b
fix: revert temporarily exclude undici-http-handler from types check
trivikr May 14, 2026
b9ab281
test: import HttpRequest from @smithy/core/protocols
trivikr May 14, 2026
5234a2c
test: suggest update undici version when dropping support for node ma…
trivikr May 14, 2026
1730a56
chore: move private getOrCreateDispatcher to the bottom
trivikr May 15, 2026
ef5fd38
chore: use destructuring with assignment as expressions in getOrCreat…
trivikr May 15, 2026
7d28db6
docs: add @public annotation for UndiciHttpHandler
trivikr May 15, 2026
aacd105
chore: store timeout in a variable before assigning
trivikr May 15, 2026
0035a7c
chore: delete expect header only if the value is '100-continue'
trivikr May 15, 2026
d77b94b
chore: delete 'transfer-encoding' header only if the value is 'chunked'
trivikr May 15, 2026
8bf7691
fix: 'requestTimeout' is possibly 'undefined'
trivikr May 15, 2026
ebf2fab
feat: accept Agent.Options in dispatcher config
trivikr May 15, 2026
8c3a032
docs: add low overhead Client option in README
trivikr May 15, 2026
d355253
chore: allow undefined in updateHttpClientConfig but keep dispatcher …
trivikr May 15, 2026
f909f89
chore: close previous internal dispatcher when updating with a new Di…
trivikr May 15, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-mangos-relate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/undici-http-handler": major
---

Add HttpHandler backed by Node.js undici
4 changes: 4 additions & 0 deletions api-snapshot/api.json
Original file line number Diff line number Diff line change
Expand Up @@ -1321,6 +1321,10 @@
"WaiterConfiguration": "type(interface)",
"WithSdkStreamMixin": "type(object)"
},
"@smithy/undici-http-handler": {
"UndiciHttpHandler": "function",
"UndiciHttpHandlerOptions": "type(interface)"
},
"@smithy/url-parser": {
"parseUrl": "function"
},
Expand Down
8 changes: 8 additions & 0 deletions packages/undici-http-handler/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/node_modules/
/build/
/coverage/
/docs/
*.tsbuildinfo
*.tgz
*.log
package-lock.json
6 changes: 6 additions & 0 deletions packages/undici-http-handler/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Change Log

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

See [@smithy/undici-http-handler](https://github.com/smithy/smithy-typescript/blob/main/packages/undici-http-handler/CHANGELOG.md) for additional history.
201 changes: 201 additions & 0 deletions packages/undici-http-handler/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2018-2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
68 changes: 68 additions & 0 deletions packages/undici-http-handler/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# @smithy/undici-http-handler

[![NPM version](https://img.shields.io/npm/v/@smithy/undici-http-handler/latest.svg)](https://www.npmjs.com/package/@smithy/undici-http-handler)
[![NPM downloads](https://img.shields.io/npm/dm/@smithy/undici-http-handler.svg)](https://www.npmjs.com/package/@smithy/undici-http-handler)

Smithy-compatible HTTP handler backed by Node.js [undici][].

## Usage

Use `UndiciHttpHandler` as a Smithy-compatible request handler for generated
clients. It uses undici for HTTP transport, and accepts optional undici
`Dispatcher` to set up transport details.

### Basic example

```js
import { S3 } from "@aws-sdk/client-s3";
import { UndiciHttpHandler } from "@smithy/undici-http-handler";

const client = new S3({
requestHandler: new UndiciHttpHandler(),
});

client.listBuckets().then(console.log);
```

### Configuring undici Dispatcher

Pass an undici `Dispatcher` to configure transport behavior such as connection
pooling and timeouts.

```js
import { S3 } from "@aws-sdk/client-s3";
import { UndiciHttpHandler } from "@smithy/undici-http-handler";
import { Agent } from "undici";

const dispatcher = new Agent({
connections: 50,
headersTimeout: 3000,
bodyTimeout: 3000,
connect: {
timeout: 3000,
},
});

const client = new S3({
requestHandler: new UndiciHttpHandler({ dispatcher }),
Comment thread
trivikr marked this conversation as resolved.
});

client.listBuckets().then(console.log);
```

## Benchmarks

Our benchmark spin up a local HTTP server and runs two scenarios:

- **10 sequential GETs** – measures per-request latency when requests are issued
one after another.
- **50 concurrent GETs** – measures throughput under parallel load using
`Promise.all`.

The results show UndiciHttpHandler spends **20%-30%** less time in request handling
as compared to NodeHttpHandler from `@smithy/node-http-handler`.

We recommend running benchmarks for your own use case on your own setup, as
results will vary depending on workload, network conditions, and environment.

[undici]: https://undici.nodejs.org/
4 changes: 4 additions & 0 deletions packages/undici-http-handler/api-extractor.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"extends": "../../api-extractor.packages.json",
"mainEntryPointFilePath": "./dist-types/index.d.ts"
}
72 changes: 72 additions & 0 deletions packages/undici-http-handler/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
{
"name": "@smithy/undici-http-handler",
"version": "0.5.0",
"description": "Smithy-compatible HTTP handler backed by Node.js undici",
"scripts": {
"build": "concurrently 'yarn:build:types' 'yarn:build:es:cjs'",
"build:es:cjs": "yarn g:tsc -p tsconfig.es.json && node ../../scripts/inline undici-http-handler",
"build:types": "yarn g:tsc -p tsconfig.types.json",
"build:types:downlevel": "premove dist-types/ts3.4 && downlevel-dts dist-types dist-types/ts3.4",
"clean": "premove dist-cjs dist-es dist-types tsconfig.cjs.tsbuildinfo tsconfig.es.tsbuildinfo tsconfig.types.tsbuildinfo",
"extract:docs": "api-extractor run --local",
"format": "prettier --config ../../prettier.config.js --ignore-path ../../.prettierignore --write \"**/*.{ts,md,json}\"",
"lint": "eslint -c ../../.eslintrc.js \"src/**/*.ts\"",
"stage-release": "premove .release && yarn pack && mkdir ./.release && tar zxvf ./package.tgz --directory ./.release && rm ./package.tgz",
"test": "yarn g:vitest run",
"test:bench": "yarn g:vitest bench --config vitest.config.bench.mts",
"test:watch": "yarn g:vitest watch"
},
"author": {
"name": "AWS SDK for JavaScript Team",
"email": "",
"url": "https://aws.amazon.com/javascript/"
},
"license": "Apache-2.0",
"sideEffects": false,
"main": "./dist-cjs/index.js",
"module": "./dist-es/index.js",
"types": "./dist-types/index.d.ts",
"dependencies": {
"@smithy/core": "workspace:^",
"@smithy/types": "workspace:^",
"tslib": "^2.6.2",
"undici": "^6.0.0"
},
"devDependencies": {
"@smithy/abort-controller": "workspace:^",
"@smithy/node-http-handler": "workspace:^",
"@types/node": "^18.11.9",
"concurrently": "7.0.0",
"downlevel-dts": "0.10.1",
"premove": "4.0.0",
"typedoc": "0.23.23"
},
"peerDependencies": {
"undici": "^6.0.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only appear in one of deps and peerDeps, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A module, when it appears in both dependencies and peerDependencies within a package.json file, it usually means a default fallback for the dependency.

When we specify undici@^6.0.0 in dependencies, that mean it's the default. When we specify undici@^6.0.0 in peerDepedencies, it means customers can use those versions when passing their custom dispatcher.

The handler as it's currently designed will accept 7.x and 8.x versions of undici too, if customers on newer versions of Node.js and want to avail performance benefits.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered removing undici from dependencies and asking customers to provide a dispatcher.
But customers will have to import both the handler and undici, which won't be a good minimal experience.

Existing minimal code

import { S3 } from "@aws-sdk/client-s3";
import { UndiciHttpHandler } from "@smithy/undici-http-handler";

const client = new S3({
  requestHandler: new UndiciHttpHandler(),
});

Minimal code if we require customer to pass dispatcher

import { S3 } from "@aws-sdk/client-s3";
import { UndiciHttpHandler } from "@smithy/undici-http-handler";
import { Agent } from "undici";

const client = new S3({
  requestHandler: new UndiciHttpHandler({ dispatcher: new Agent() }),
});

I think the former is better.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so should the one in peerDep be stated as >=6.0.0 then?

},
"engines": {
"node": ">=18.0.0"
},
"typesVersions": {
"<4.5": {
"dist-types/*": [
"dist-types/ts3.4/*"
]
}
},
"files": [
"dist-*/**"
],
"homepage": "https://github.com/smithy-lang/smithy-typescript/tree/main/packages/undici-http-handler",
"repository": {
"type": "git",
"url": "https://github.com/smithy-lang/smithy-typescript.git",
"directory": "packages/undici-http-handler"
},
"typedoc": {
"entryPoint": "src/index.ts"
},
"publishConfig": {
"directory": ".release/package"
}
}
2 changes: 2 additions & 0 deletions packages/undici-http-handler/src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export { UndiciHttpHandler } from "./undici-http-handler";
export type { UndiciHttpHandlerOptions } from "./undici-http-handler";
Loading
Loading