fix(node-http-handler): destroy isolated HTTP/2 sessions and type timeout errors - #2223
Open
siddsriv wants to merge 2 commits into
Open
fix(node-http-handler): destroy isolated HTTP/2 sessions and type timeout errors#2223siddsriv wants to merge 2 commits into
siddsriv wants to merge 2 commits into
Conversation
siddsriv
force-pushed
the
fix/node-http2-handler-session-leak
branch
from
August 11, 2026 19:19
4726660 to
df0cb55
Compare
siddsriv
commented
Aug 11, 2026
| // Arm a session timeout as a safety net to reap orphaned sessions. | ||
| // Uses the configured sessionTimeout if provided, otherwise defaults to | ||
| // 5 minutes to prevent indefinite leaks when other cleanup paths fail. | ||
| const timeout = connectionConfiguration.requestTimeout ?? 300_000; |
Contributor
Author
There was a problem hiding this comment.
lmk if any objections to a 5 min limit, or if you have recommendations
Contributor
There was a problem hiding this comment.
is this safe w.r.t. the upcoming default timeouts specification?
Contributor
Author
There was a problem hiding this comment.
yeah i think so, going to re-confirm
siddsriv
force-pushed
the
fix/node-http2-handler-session-leak
branch
from
August 11, 2026 19:21
df0cb55 to
c592535
Compare
siddsriv
force-pushed
the
fix/node-http2-handler-session-leak
branch
from
August 17, 2026 17:30
c592535 to
8e4e70b
Compare
siddsriv
marked this pull request as ready for review
August 20, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2202
Description of changes:
If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.