ci: skip the ci workflow on the release PR - #2241
Closed
trivikr wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
During post-scrum on 8/18, we decided to retain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The changesets release PR only bumps versions, rewrites the inter-package dependency ranges to match, writes changelogs and deletes the consumed changesets. It touches no Java or TypeScript source, and
release-dry-run.ymlalready installs, builds and packs that exact tree.Guard every job rather than the trigger, since a pull_request event's branch filters match the base branch and there is no workflow-level if. This makes the step-level guard on the changeset status check redundant, so it moves up to the job.
The run is still created and still queued for approval before any of these conditions are evaluated, so ci stays in EXPECTED_WORKFLOWS in create-release-pr.yml, which is what approves it. It now completes as skipped rather than running the Java matrix, five Node test legs, protocol tests and docs extraction.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.