Increase severity for endpoint test NVV validation#2593
Merged
Conversation
alextwoods
approved these changes
Apr 15, 2025
yefrig
approved these changes
Apr 15, 2025
This commit increases the validation event severity, from WARNING to DANGER, for cases where the input to an operationInputs endpoint test does not match the requirements of the input shape. There does not appear to be a use case for this behavior and it is believed that this was mistakenly lowered from ERROR to WARNING in a previous commit. It is increased only to DANGER to allow for a suppression in cases we do not foresee.
kstich
force-pushed
the
increase_endpoint_test_nvv_validation
branch
from
167ab08 to
f8449f8
Compare
yefrig
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit increases the validation event severity, from WARNING to DANGER, for cases where the input to an operationInputs endpoint test does not match the requirements of the input shape.
There does not appear to be a use case for this behavior and it is believed that this was mistakenly lowered from ERROR to WARNING in a previous commit. It is increased only to DANGER to allow for a suppression in cases we do not foresee.
Context
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.