Use ordered sets for shape id sequences#2742
Merged
JordonPhillips merged 2 commits intoAug 15, 2025
Merged
Conversation
Several shapes have properties that are sequences of shape ids, such as an OperationShape's errors. Previously these shapes were using the List structure to store these in Java, but since the order of these sequences isn't actually semantically important, it was causing equality checks to fail where the should not. This replaces those usages of `List` to `LinkedHashSet`. That way the order in the model may still be preserved, but the equality is set equality. Additionally, duplicates in these sequences have no meaning, so the deduplication of sets is a benefit in that sense too.
JordonPhillips
requested review from
joewyz and
yefrig
and removed request for
joewyz
yefrig
approved these changes
Aug 14, 2025
Co-authored-by: Yefri Gaitan <34199474+yefrig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several shapes have properties that are sequences of shape ids, such as an OperationShape's errors. Previously these shapes were using the List structure to store these in Java, but since the order of these sequences isn't actually semantically important, it was causing equality checks to fail where the should not.
This replaces those usages of
ListtoLinkedHashSet. That way the order in the model may still be preserved, but the equality is set equality. Additionally, duplicates in these sequences have no meaning, so the deduplication of sets is a benefit in that sense too.Fixes #2735
Note that we already use ordered sets for the lists of operations and resources on service and resource shapes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.