Fix a bug that prevented warning events to show up for diff CLI command#2749
Merged
sugmanue merged 2 commits intoAug 20, 2025
Merged
Conversation
The severity is set to DANGER to load the old and new models to avoid events of lesser severity to show up during loading. After this was done the option was mutated and the attempt to restore the default severity didn't work. Now, the validation option keeps a different field to distinguish the value read from the CLI from overrides to be able to tell them apart and properly reset these when needed.
joewyz
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The severity is set to
DANGERto load the old and new models to avoid events of lesser severity to show up during loading. After this was done the option was mutated and the attempt to restore the default severity didn't work. Now, the validation option keeps a different field to distinguish the value read from the CLI from overrides to be able to tell them apart and properly reset these when needed.Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.