Add xmlAttributesInMiddle protocol test #2870
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This change is in response to a bug found in C# while generating S3, where we weren't correctly writing xmlAttributes to the correct XmlElement. This was never caught in our generator since S3 had it correctly done by hand. This caused us to ship a bug which we quickly fixed.
In languages like C# where writing an xmlAttribute happens like so:
the ordering of the
WriteAttributeStringcall matters, and so this test adds a test case where the@xmlAttributeis defined in the middle of the member list.Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.