Add trait to declare types for metadata#3078
Open
JordonPhillips wants to merge 2 commits into
Open
Conversation
This adds a new trait to declare types for metadata keys. Values for these keys will be validated against the shape targeted by the trait. While this enables modeling of the suppressions and validators keys, actually adding those to the model will be done later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
joewyz
reviewed
Apr 30, 2026
Contributor
There was a problem hiding this comment.
nit: should we totally blank file for valid test error files?
joewyz
reviewed
Apr 30, 2026
Contributor
There was a problem hiding this comment.
nit: same as the previous comment on valid test error files.
joewyz
reviewed
Apr 30, 2026
| import software.amazon.smithy.model.shapes.ShapeId; | ||
| import software.amazon.smithy.model.shapes.StringShape; | ||
|
|
||
| public class MetadataTraitTest { |
Contributor
There was a problem hiding this comment.
nit: Should we have a test for conflict key defined in different files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new trait to declare types for metadata keys. Values for these keys will be validated against the shape targeted by the trait.
While this enables modeling of the suppressions and validators keys, actually adding those to the model will be done later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.