Skip to content

Fix Windows PATH issue in install.bat #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kstich merged 3 commits into from
May 14, 2026
Merged

Fix Windows PATH issue in install.bat #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea9700b
Fix Windows PATH issue in install.bat
dscpinheiro May 14, 2026
d81f99d
Fix message
dscpinheiro May 14, 2026
65e16a6
Add changelog
dscpinheiro May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/next-release/bugfix-fab9cf64f935850c592eca38cab212cba6579149.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "bugfix",
"description": "Fix Windows user PATH corruption in install.bat caused by setx silently truncating values over 1024 characters",
"pull_requests": [
"[#3117](https://github.com/smithy-lang/smithy/pull/3117)"
]
}
9 changes: 7 additions & 2 deletions smithy-cli/configuration/install.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ if exist "%choice_path%" goto upgrade

:: Copy the installation
xcopy /i /h /e /k "%installer_path%*" "%choice_path%\"
setx path "%path%;%choice_path%\;"
call %exe_name% warmup
set "smithy_install_dir=%choice_path%"
powershell -Command "& { $installDir = $env:smithy_install_dir; $userPath = [Environment]::GetEnvironmentVariable('PATH','User'); if ([string]::IsNullOrEmpty($userPath)) { [Environment]::SetEnvironmentVariable('PATH', $installDir, 'User') } elseif (-not $userPath.Contains($installDir)) { [Environment]::SetEnvironmentVariable('PATH', $userPath.TrimEnd(';') + ';' + $installDir, 'User') } }"
Comment thread
kstich marked this conversation as resolved.
if %ERRORLEVEL% neq 0 (
echo Failed to update PATH. You may need to add %choice_path% to your PATH manually.
goto done
)
call "%choice_path%\bin\%exe_name%" warmup
echo You may now run '%exe_name% --version'
goto done

Expand Down
Loading