Skip to content

make the blob params in the event stream tests not b64#3121

Merged
kstich merged 2 commits into
smithy-lang:mainfrom
lucix-aws:fix-blob64
May 14, 2026
Merged

make the blob params in the event stream tests not b64#3121
kstich merged 2 commits into
smithy-lang:mainfrom
lucix-aws:fix-blob64

Conversation

@lucix-aws
Copy link
Copy Markdown
Contributor

@lucix-aws lucix-aws commented May 14, 2026

Background

  • What do these changes do?
    • All of the blob params in our protocoltests are plaintext, but some in the new eventstream ones were b64
  • Why are they important?
    • consistency

Testing

  • How did you test these changes?
    • Ran the event stream tests in smithy-go

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucix-aws lucix-aws requested a review from a team as a code owner May 14, 2026 16:23
@lucix-aws lucix-aws requested a review from JordonPhillips May 14, 2026 16:23
@github-actions
Copy link
Copy Markdown
Contributor

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#3121" --type feature --description "make the blob params in the event stream tests not b64"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

@kstich kstich merged commit f2e2858 into smithy-lang:main May 14, 2026
13 checks passed
@lucix-aws lucix-aws deleted the fix-blob64 branch May 14, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants