Fix onErrorStatusConflict set via updateDefaultSettings#3123
Merged
kstich merged 1 commit intoMay 14, 2026
Conversation
The error deconflicting logic in `OpenApiConverter` read `config.getOnErrorStatusConflict()` before either `composedMapper.updateDefaultSettings` or `openApiProtocol.updateDefaultSettings` was called. This made it impossible for protocols or mappers to set the strategy. Move the deconflict block to after both `updateDefaultSettings` calls, and set the model and config on the JSON schema converter builder afterward so they reflect the final state.
yasmewad
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error deconflicting logic in
OpenApiConverterreadconfig.getOnErrorStatusConflict()before eithercomposedMapper.updateDefaultSettingsoropenApiProtocol.updateDefaultSettingswas called. This made it impossible for protocols or mappers to set the strategy.Move the deconflict block to after both
updateDefaultSettingscalls, and set the model and config on the JSON schema converter builder afterward so they reflect the final state.Fixes #3120
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.