Skip to content

Allow tagMap/tagsMap variants for tag member name#3129

Open
taylorlo-aws wants to merge 3 commits into
smithy-lang:mainfrom
taylorlo-aws:tagmap-tagsmap-variants
Open

Allow tagMap/tagsMap variants for tag member name#3129
taylorlo-aws wants to merge 3 commits into
smithy-lang:mainfrom
taylorlo-aws:tagmap-tagsmap-variants

Conversation

@taylorlo-aws
Copy link
Copy Markdown

Background

  • What do these changes do?

Map shapes (string -> string) are already a valid representation for tags in TagResource/ListTagsForResource per verifyTagsShape, but the member-name regex only accepted Tags/TagList variants. Loosen the TAG_PROPERTY_REGEX to also accept TagMap/tagMap/TagsMap/tagsMap (and case variants), aligning name validation with the shape validation that already supports maps.

  • Why are they important?

Services that may use the map shape for their tags may want to align the member names with that type for internal consistency in their API fields.

Testing

  • How did you test these changes?

Ran all existing tests and added valid tagMembers test case.

Links

  • Links to additional context, if necessary

N/A

  • Issue #, if applicable (see here for a list of keywords to use for linking issues)

N/A


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Map shapes (string -> string) are already a valid representation for
tags in TagResource/ListTagsForResource per verifyTagsShape, but the
member-name regex only accepted Tags/TagList variants. Loosen the
TAG_PROPERTY_REGEX to also accept TagMap/tagMap/TagsMap/tagsMap (and
case variants), aligning name validation with the shape validation
that already supports maps.
@taylorlo-aws taylorlo-aws requested a review from a team as a code owner May 15, 2026 18:35
@taylorlo-aws taylorlo-aws requested a review from joewyz May 15, 2026 18:35
…f03623ec.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment thread .changes/next-release/feature-d17968aca46bca4363e20d02a48b457df03623ec.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants