Add apiConfig to aws.api#tagEnabled for renamed tagging operations#3130
Open
taylorlo-aws wants to merge 3 commits into
Open
Add apiConfig to aws.api#tagEnabled for renamed tagging operations#3130taylorlo-aws wants to merge 3 commits into
taylorlo-aws wants to merge 3 commits into
Conversation
Allow services that model tagging via non-default operation names (e.g., AddTagsToResource instead of TagResource) to keep validation and tag discovery on. The new TaggableServiceApiConfig structure has three optional ShapeID slots (tagApi, untagApi, listTagsApi); each unset slot falls back to the default-named operation. Resource-level apiConfig still wins over service-level for resource-bound resolution. AwsTagIndex now resolves the per-service tagging op slots via the service-level apiConfig before falling back to default-named lookups. A new TagEnabledServiceValidator check warns when an apiConfig override coexists with the default-named operation in the service operations list, so modelers either drop the override or remove the dead op.
…e402c1e5.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kstich
reviewed
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Allow services that model tagging via non-default operation names (e.g., AddTagsToResource instead of TagResource) to keep validation and tag discovery on. The new TaggableServiceApiConfig structure has three optional ShapeID slots (tagApi, untagApi, listTagsApi); each unset slot falls back to the default-named operation. Resource-level apiConfig still wins over service-level for resource-bound resolution.
AwsTagIndex now resolves the per-service tagging op slots via the service-level apiConfig before falling back to default-named lookups. A new TagEnabledServiceValidator check warns when an apiConfig override coexists with the default-named operation in the service operations list, so modelers either drop the override or remove the dead op.
Services like RDS use service level tagging operations that are not named the default. This change allows the usage of
tagEnabledto semantically associate these non-standard tagging APIs in the model so that consumers can find them while still applying the existing validation.Testing
All existing model test cases pass; this change is backwards compatible. New model test cases were added to validate the new override + fallback behavior.
Links
N/A
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.