fix: Fix missing kita action mapping in 3P observation Python bridge - #164
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the 3-player (Sanma) Python bridge action selection so that MJAI "kita" actions are recognized and mapped to the internal ActionType::Kita, preventing select_action_from_mjai from returning None for nuki-dora plays.
Changes:
- Add missing
"kita"match arm inObservation3P::select_action_from_mjaito map tocrate::action::ActionType::Kita.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
"kita"match arm inselect_action_from_mjaifor 3P observation.Fixes #163
Thanks for the bug report! @shinkuan, @Apricot-S