Preserve tag-key case in context_key() (#14) - #18
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72838fc. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #14
Note
Medium Risk
Changes IAM evaluation context key matching for tag-based conditions; correct for AWS semantics but may alter outcomes where policies depended on fully lowercased tag keys.
Overview
Fixes #14 by aligning how
RequestContextstores and looks up keys fromcontext_key(),context_key_multi(), andget_context_key().A new
normalize_context_keylowercases only theaws:PrincipalTag/,aws:ResourceTag/, andaws:RequestTag/prefixes (prefix match is case-insensitive) and keeps the tag name after/unchanged, matching AWS case-sensitive tag keys. All other context keys are still fully lowercased.Regression tests cover principal/resource/request tag keys, mixed-case prefixes, multi-value tags, non-tag keys, and round-trip via
get_context_key.Reviewed by Cursor Bugbot for commit 3e30d10. Bugbot is set up for automated code reviews on this repo. Configure here.