Strip IAM user path when deriving aws:username (#15) - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
Note
Low Risk
Localized ARN parsing fix for one policy variable with added regression tests; no auth or broad eval redesign.
Overview
Fixes
${aws:username}when the principal is an IAM user whose ARN includes a path (e.g.user/developers/johndoe). Previously the whole suffix afteruser/was used as the username; it now returns only the final path segment, matching AWS behavior (usernames cannot contain/).Assumed-role and federated-user ARN handling is unchanged. New unit tests cover flat, single-segment, and deep IAM user paths.
Reviewed by Cursor Bugbot for commit cef8bf5. Bugbot is set up for automated code reviews on this repo. Configure here.