Replace recursive glob with iterative two-pointer algorithm (#10) - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Note
Low Risk
Localized algorithm swap with preserved semantics and regression coverage; no API or auth changes.
Overview
Fixes performance and potential DoS in ARN wildcard matching by replacing the recursive
glob_matchimplementation with an iterative two-pointer matcher that backtracks only from the last*.Pathological patterns such as many interleaved
*a*segments against long text could drive exponential recursive retries (~11s on a small example in #10); the new approach targets O(|pattern| × |text|) worst case. Public behavior for*and?is unchanged;ArnPatternstill matches each ARN segment viaglob_match.Adds
test_glob_no_exponential_blowup, asserting a known adversarial case finishes in under 100ms and does not match.Reviewed by Cursor Bugbot for commit 1c16738. Bugbot is set up for automated code reviews on this repo. Configure here.