Fix cross-account sts:AssumeRole requires identity policy (#8) - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Note
Medium Risk
Changes authorization outcomes for cross-account role assumption in the IAM evaluator—callers relying on the old trust-only
AssumeRolebehavior will see denies until identity policies are modeled.Overview
Cross-account IAM evaluation no longer treats all
sts:AssumeRole*actions as trust-policy-only. The engine now applies the trust policy alone shortcut only forsts:AssumeRoleWithSAMLandsts:AssumeRoleWithWebIdentity(still case-insensitive).sts:AssumeRoleis evaluated like other cross-account calls: identity and resource policies must both allow; trust policy by itself yields implicit deny on the identity side.Unit and integration tests were split and retargeted: SAML/WebIdentity trust-only allow paths remain; plain
AssumeRolewith trust only now expects deny; case-insensitivity coverage usesAssumeRoleWithSAMLinstead ofAssumeRole.Reviewed by Cursor Bugbot for commit af0db0f. Bugbot is set up for automated code reviews on this repo. Configure here.