fast retransmit fix#1155
Open
JPDye wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
+ Coverage 81.48% 81.52% +0.03%
==========================================
Files 81 81
Lines 25007 25045 +38
==========================================
+ Hits 20378 20417 +39
+ Misses 4629 4628 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d14a8bf to
54b8fec
Compare
…urate estimations
54b8fec to
235c8c7
Compare
Dirbaio
reviewed
Jun 14, 2026
| let offset = self.remote_last_seq - self.local_seq_no; | ||
| repr.payload = self.tx_buffer.get_allocated(offset, size); | ||
| let offset = if self.pending_fast_retransmit { | ||
| let size = effective_mss.min(self.tx_buffer.len()); |
Member
There was a problem hiding this comment.
it's possible self.cwnd_remaining() is 0, which would cause effective_mss to be 0. I think fast retransmit needs to be exempted from cc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR. Requires #1156 and CUBIC. Will rebase once that merges.
Previously, the fast retransmit would send the entire buffer. Now, it only sends the oldest segment. On the single flow netsim, performance regresses and on the multiflow netsim (#1153) performance is significantly improved. This is because fast-retransmit works better with "realistic" tail drop loss better than it does random loss.
These performance losses are somewhat regained by changing the
RTTEstimatorto handle RTO differently to individual retransmissions, but still leave the single flow reasonably worse off when random loss occurs.Single flow:
Multiflow: