Add wire representations for SRv6 header as part of IPv6 Routing header#610
Open
ngc0202 wants to merge 2 commits into
Open
Add wire representations for SRv6 header as part of IPv6 Routing header#610ngc0202 wants to merge 2 commits into
ngc0202 wants to merge 2 commits into
Conversation
Contributor
Contributor
Author
|
@thvdveld I have a bunch of local changes, but most wasn't really intended to be pushed up. Stuff like some higher-level methods for working with TLVs and the like, I wasn't really sure what was suitable for the PR. I did have a bug in here that I never pushed the fix for however: Besides that I think it's good to go as is, with whatever changes you see fit. |
Contributor
|
I thought I needed this for RPL, but it's source routing that I need (which is already in there). Maybe if you could add some tests for the parsing of SRv6 packets, that would be nice. |
Contributor
|
Could you maybe add tests for parsing/emitting? I think that we can merge this after the tests are added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first of what is likely to be multiple PRs for working with SRv6 with smoltcp! For now, this is just the wire representations. I believe I implemented all the necessary cases, but worth double checking it. I'm also open to suggestions on more areas that could be upgraded to work better with SRv6, and I'll be happy to work on it.