fix: proper Unicode/Chinese character handling in UI #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix garbled display of Chinese/Unicode characters in instance list and error messages by replacing byte-based string operations with proper Unicode-aware width calculations. Changes: - ui/list.go: Use runewidth.StringWidth() for width calculations and runewidth.Truncate() for safe string truncation in title and branch - ui/err.go: Same fix for error message truncation The issue was that Go's len() returns byte count, not character count. When truncating UTF-8 strings (like Chinese characters which are 3 bytes each) at byte boundaries, multi-byte characters get cut in the middle, resulting in invalid UTF-8 sequences displayed as garbled text. Fixes display of non-ASCII characters including Chinese, Japanese, Korean, emoji, etc.
When deleting characters with backspace, convert string to []rune first to delete by character instead of by byte. This fixes the issue where pressing backspace on Chinese/Unicode characters would only delete part of the multi-byte sequence, causing garbled text. Also use runewidth.StringWidth() for title length validation to properly count display width instead of byte count.
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix garbled display and incorrect backspace behavior for Chinese/Unicode characters in the TUI.
Closes #233
Problem
Chinese and other multi-byte Unicode characters were displaying as garbled text (e.g.,
是的分身艺术�) because:str[:n]), which cuts UTF-8 characters in the middlelen()which returns byte count, not display widthSolution
Use
github.com/mattn/go-runewidth(already a dependency) for proper Unicode handling:runewidth.StringWidth()- calculate actual display widthrunewidth.Truncate()- safely truncate strings without breaking characters[]rune()conversion - for character-based operations like backspaceChanges
ui/list.gorunewidthfor title/branch truncation and width calculationui/err.gorunewidthfor error message truncationapp/app.go[]runefor backspace, userunewidthfor length checkTesting
go test ./...)go build .)Screenshots
Before (Bug):
Instance names with Chinese characters show garbled text when truncated or after backspace.
After (Fixed):
Chinese characters display correctly and backspace removes whole characters.