fix: preserve original case in branch names#305
Open
mskasa wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Branch names are silently converted to lowercase by
sanitizeBranchName().For example, entering
JRA-123results in branchjra-123.This may not match the user's intended naming convention.
According to Atlassian's official documentation, Jira work item keys must use
capital letters to link correctly with development tools:
https://support.atlassian.com/jira-software-cloud/docs/reference-issues-in-your-development-work/
Root Cause
sanitizeBranchName()callsstrings.ToLower()and uses a regex that onlyallows lowercase letters
[^a-z0-9\-_/.], which together silently discarduppercase characters. The scope of this function could be limited to removing
git-invalid characters, leaving case normalization to the user's preference.
Fix
strings.ToLower()call[^a-z0-9\-_/.]to[^a-zA-Z0-9\-_/.]to allow uppercase letters after removing the lowercasing step
Reproduction
JRA-123git worktree listjra-123instead ofJRA-123