release/v0.4.0#119
Merged
Merged
Conversation
PlannerMode::Tune was a no-op stub and with_mode ignored its mode
argument. Remove the whole surface; PlannerDit{32,64}::new is now the
sole constructor.
Spell precision as the Rust float type and name the algorithm
explicitly: fft_64_dit{,_with_planner,_with_planner_and_opts} ->
fft_f64_dit* and the f32 mirror. Reserves the namespace for a future
decimation-in-frequency (_dif) family.
…terleaved The interleaved (complex-nums) API gains the explicit _dit algorithm token to match the split-array API and reserve a parallel _dif slot.
Rename the existing full-control functions to *_with_planner_and_opts and add bare and *_with_planner convenience tiers for r2c/c2r, f32 and f64. The convenience tiers compute Options for the inner N/2 FFT internally, so callers no longer have to know to pass guess_options(n/2). Adds tier- agreement tests proving the wrappers are bit-identical to the full form.
…c types Direction gains Debug/PartialEq/Eq/Hash; Options gains PartialEq/Eq; the planners derive Clone and get a terse manual Debug (a derived Debug would dump multi-megabyte twiddle vecs). Per the Rust API Guidelines C-COMMON-TRAITS / C-DEBUG. All additions are non-breaking.
The crate's docs and README describe "inverse"/"IFFT" everywhere, but the enum variant was named Reverse. Align the type with its own documentation. The discriminant (= -1) is unchanged.
Shnatsel
approved these changes
Jun 5, 2026
Shnatsel
left a comment
Shnatsel
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!
I also made another pass over the README to make sure we're not over-promising performance.
I think our headline README benchmarks are single-threaded, it would be better to switch the README to multi-threaded benchmarks and report single-thread numbers in a more detailed file about benchmarks.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
- Coverage 98.76% 98.66% -0.11%
==========================================
Files 10 10
Lines 2844 2996 +152
==========================================
+ Hits 2809 2956 +147
- Misses 35 40 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.