Convert AndOr to discriminated union #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the representation of the AndOr type from a class-based hierarchy to a discriminated union, simplifying type management and JSON encoding.
- Removed the And, Or, and Simply classes and replaced them with a union type.
- Updated the encodeJsonQ function and relevant test cases to work with the new union representation.
- Adjusted related functions in Relevance.ts to construct AndOr objects using the new union type.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/model/Interview.ts | Replaced class-based AndOr with a discriminated union and updated the JSON encoding logic. |
| src/model/tests/Interview.test.ts | Updated test cases to construct AndOr objects as union literals. |
| src/model/Relevance.ts | Modified object construction to use the new AndOr union type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.