Skip to content

Commit 0337d1c

Browse files
fix: output correct kubectl commands for changed submission approach (jobs instead of pods) (#47)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Simplified logging messages for Kubernetes job status checks. - The instructions now only reference the job-level command for retrieving job information, removing the previous guidance for fetching logs. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 51af499 commit 0337d1c

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

snakemake_executor_plugin_kubernetes/__init__.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -388,11 +388,7 @@ def run_job(self, job: JobExecutorInterface):
388388
self.logger.error(f"Failed to create pod: {e}")
389389
raise WorkflowError(f"Failed to create pod: {e}")
390390

391-
self.logger.info(
392-
"Get status with:\n"
393-
"kubectl describe pod {jobid}\n"
394-
"kubectl logs {jobid}".format(jobid=jobid)
395-
)
391+
self.logger.info("Get status with:\n" "kubectl describe job {jobid}\n")
396392

397393
self.report_job_submission(
398394
SubmittedJobInfo(job=job, external_jobid=jobid, aux={"pod": pod})
@@ -479,8 +475,7 @@ async def check_active_jobs(
479475
):
480476
msg = (
481477
"For details, please issue:\n"
482-
f"kubectl describe job {j.external_jobid}\n"
483-
f"kubectl logs {j.external_jobid}"
478+
f"kubectl describe job {j.external_jobid}"
484479
)
485480
# failed
486481
kube_log = self.log_path / f"{j.external_jobid}.log"

0 commit comments

Comments
 (0)