Feature/organizer comment notification toggle#412
Open
zhouyijun111 wants to merge 32 commits intosnap-cloud:mainfrom
Open
Feature/organizer comment notification toggle#412zhouyijun111 wants to merge 32 commits intosnap-cloud:mainfrom
zhouyijun111 wants to merge 32 commits intosnap-cloud:mainfrom
Conversation
The sign-up form silently fails when validation errors occur (e.g., duplicate username, password too short, password mismatch) because the Devise registration views never render resource.errors. Add error message rendering to the _form_fields partial so users see clear feedback when registration fails. Fixes #61
Fix registration form not displaying validation errors
Implement a new feature (Issue #54) to duplicate events within a conference
Replace legacy Stripe Charges API with modern Checkout Sessions API. Users are redirected to Stripe-hosted payment page with itemized ticket breakdown, multi-currency support, and session-based payment confirmation. Also fixes registration form error display, payment button layout, and various linter offenses.
Add Feature - conference duplication
…ment-notification-toggle Made-with: Cursor # Conflicts: # db/schema.rb
Contributor
Author
|
@cycomachead Could you review this PR from the cs169:main repo to the golden repo? Thanks! |
Member
|
This PR has some conflicts and contains payments and a few other fixes. It's probably hard to back out the other merges, but if we could resolve the conflicts and open a payments-only PR that would make this easier to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds an organizer-level toggle to control whether “proposal comment” notification emails are sent to organizers.
Changes
users_roles.email_notifications(default: enabled).Admin::RolesController#toggle_comment_notificationsto persist the preference.AdminAbilityto allow the toggle action.email_notifications = true.osem-switch.jshandling to prevent incorrect auto-triggering during initialization/cache restore.Test plan
No.letter_openerthat no email is sent to that organizer.Yes.letter_openerthat an email is sent.Screenshot