feat: add vp value to leaderboard

[wa0x6e]

Summary

Adds vp_value tracking to the leaderboard table and defers vote deletion to an async background script. Leaderboard updates use idempotent SUM/COUNT queries from the votes table instead of fragile delta-based increments, preventing drift from re-votes, race conditions, or missed updates.

Background workers (votesVpValue, scores, shutter) now guard against overwriting cb=PENDING_DELETE set by delete-proposal, preventing a race condition where votes marked for deletion could be orphaned.

Changes

• ✨ Add vp_value column to the leaderboard table
• ✨ Add PENDING_DELETE constant (cb = -3) for soft-deleting votes
• ✨ Add deleteProposalVotes async script to process pending vote deletions in batches
• ♻️ delete-proposal writer: mark votes as PENDING_DELETE instead of deleting inline
• ♻️ votesVpValue: refresh leaderboard vp_value using SUM(vp_value) from votes table (idempotent)
• ♻️ deleteProposalVotes: refresh leaderboard vote_count and vp_value using COUNT(*)/SUM() via single JOIN subquery (idempotent)
• 🐛 votesVpValue: guard vote cb update with AND cb = PENDING_COMPUTE to prevent overwriting PENDING_DELETE
• 🐛 scores: guard vote update with AND cb != PENDING_DELETE to prevent overwriting deletion state
• 🐛 shutter: skip PENDING_DELETE votes during decryption to avoid wasted work and inconsistency

Benchmark

Tested against production database (68M+ votes). All queries use the PRIMARY KEY (voter, space, proposal) index.

Query	Time
SUM(vp_value) WHERE voter+space (single pair)	~500ms
Batch leaderboard refresh (50 pairs)	1,123ms
Batch leaderboard refresh (200 pairs)	797ms
Batch leaderboard refresh (500 pairs)	1,355ms

~500ms is mostly network latency to PlanetScale. The query itself is near-instant (PK index lookup).

Test plan

• Verify vp_value column is added to leaderboard table
• Verify votes are marked cb = -3 on proposal deletion instead of being deleted inline
• Verify deleteProposalVotes script picks up and deletes pending votes
• Verify leaderboard vp_value is refreshed correctly after vote vp_value computation
• Verify leaderboard vote_count and vp_value are correct after vote deletion
• Verify background workers do not overwrite PENDING_DELETE on votes mid-deletion

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

This PR adds voting power value tracking to the leaderboard system by introducing a new vp_value column that accumulates the total voting power value for each user across spaces and proposals.

• Adds vp_value column to the leaderboard table schema with appropriate indexing
• Updates vote creation logic to increment the user's voting power value in the leaderboard
• Implements voting power value decrementation when proposals are deleted

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
test/schema.sql	Adds vp_value DECIMAL column and index to leaderboard table
src/writer/vote.ts	Updates vote creation to track and increment voting power values in leaderboard
src/writer/delete-proposal.ts	Implements batch processing to decrement voting power values when proposals are deleted
src/helpers/entityValue.ts	Refactors vote value calculation using reduce for better readability

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ChaituVR]

Claude says this: (But i didn't verify code myself but it sounds reasonable)

The Orphaned Vote Bug — Step by Step

Setup: Alice voted on Proposal P1 in space aave.eth. Her vote has cb = PENDING_COMPUTE, vp_value = 0.

Step 0: votesVpValue wakes up, starts its cycle.
Step 1: getPendingVotes() runs:

SELECT id, voter, space, proposal FROM votes WHERE cb = -1 LIMIT 500
Returns: { id: 'vote_abc', voter: 'alice', space: 'aave.eth', proposal: 'P1' }

Steps 2: getProposalVpValues() runs:

SELECT id, cb, vp_value_by_strategy FROM proposals WHERE cb IN (-1,-2,1,-10) AND votes > 0
Returns: { id: 'P1', vpValueByStrategy: [0.5, 1.2] } — proposal exists, all good.

Step 3: A moderator deletes Proposal P1. delete-proposal.ts runs atomically:

DELETE FROM proposals WHERE id = 'P1';
UPDATE votes SET cb = -3 WHERE proposal = 'P1';  -- PENDING_DELETE
UPDATE leaderboard SET proposal_count = GREATEST(proposal_count - 1, 0) WHERE user = 'mod' AND space = 'aave.eth';
UPDATE spaces SET proposal_count = GREATEST(proposal_count - 1, 0) WHERE id = 'aave.eth';
Alice's vote is now cb = -3 (PENDING_DELETE) in the database.

Step 4: votesVpValue doesn't know any of this happened. It still has the old data from Time 1-2. It computes vp_value = 100 and runs refreshVotesVpValues():

UPDATE votes SET vp_value = 100, cb = 1 WHERE id IN ('vote_abc');
UPDATE leaderboard l SET vp_value = COALESCE((
  SELECT SUM(v.vp_value) FROM votes v WHERE v.voter = l.user AND v.space = l.space
), 0) WHERE (l.user, l.space) IN (('alice', 'aave.eth'));

This overwrites cb = -3 (PENDING_DELETE) with cb = 1 (FINAL).

[wa0x6e]

Claude says this: (But i didn't verify code myself but it sounds reasonable)

The Orphaned Vote Bug — Step by Step

Setup: Alice voted on Proposal P1 in space aave.eth. Her vote has cb = PENDING_COMPUTE, vp_value = 0.

Step 0: votesVpValue wakes up, starts its cycle. Step 1: getPendingVotes() runs:

SELECT id, voter, space, proposal FROM votes WHERE cb = -1 LIMIT 500
Returns: { id: 'vote_abc', voter: 'alice', space: 'aave.eth', proposal: 'P1' }

Steps 2: getProposalVpValues() runs:

SELECT id, cb, vp_value_by_strategy FROM proposals WHERE cb IN (-1,-2,1,-10) AND votes > 0
Returns: { id: 'P1', vpValueByStrategy: [0.5, 1.2] } — proposal exists, all good.

Step 3: A moderator deletes Proposal P1. delete-proposal.ts runs atomically:

DELETE FROM proposals WHERE id = 'P1';
UPDATE votes SET cb = -3 WHERE proposal = 'P1';  -- PENDING_DELETE
UPDATE leaderboard SET proposal_count = GREATEST(proposal_count - 1, 0) WHERE user = 'mod' AND space = 'aave.eth';
UPDATE spaces SET proposal_count = GREATEST(proposal_count - 1, 0) WHERE id = 'aave.eth';
Alice's vote is now cb = -3 (PENDING_DELETE) in the database.

Step 4: votesVpValue doesn't know any of this happened. It still has the old data from Time 1-2. It computes vp_value = 100 and runs refreshVotesVpValues():

UPDATE votes SET vp_value = 100, cb = 1 WHERE id IN ('vote_abc');
UPDATE leaderboard l SET vp_value = COALESCE((
  SELECT SUM(v.vp_value) FROM votes v WHERE v.voter = l.user AND v.space = l.space
), 0) WHERE (l.user, l.space) IN (('alice', 'aave.eth'));

This overwrites cb = -3 (PENDING_DELETE) with cb = 1 (FINAL).

A valid concern, now fixed

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wa0x6e]

@ChaituVR Race conditions should be fixed now

[ChaituVR]

utAck, but haven't tested 🙈