This repository was archived by the owner on May 11, 2026. It is now read-only.
feat: pull overriding strategies from strategies list#585
Open
wa0x6e wants to merge 7 commits into
Open
Conversation
wa0x6e
force-pushed
the
feat-pull-overriding-strategies-from-strategies-list
branch
from
August 28, 2025 22:03
1dfdecf to
35a58dc
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the strategy override detection to use the overriding strategies list from the score-api as the source of truth, replacing the hardcoded list of override strategy names.
- Extracts overriding strategies from the score-api response using the
overrideproperty - Simplifies the
hasStrategyOverridefunction to use this dynamic list instead of hardcoded keywords - Adds comprehensive test coverage for the new override detection logic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/helpers/strategies.ts | Adds extraction and storage of overriding strategies from API response |
| src/helpers/utils.ts | Simplifies override detection using dynamic strategy list |
| test/unit/helpers/utils.test.ts | Adds comprehensive test coverage for the new override detection function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ChaituVR
reviewed
Aug 30, 2025
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
wa0x6e
force-pushed
the
feat-pull-overriding-strategies-from-strategies-list
branch
from
August 30, 2025 17:51
7c25430 to
699420d
Compare
ChaituVR
reviewed
Feb 10, 2026
ChaituVR
suggested changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strategies list returned by score-api now returns the correct property for overriding strategies snapshot-labs/score-api#1377
We were already reading this list, and assigning the
overrideproperty in strategy.ts, but not using it.This PR will use the strategies list from score-api as source of truth for overriding strategies
Tests