chore: simplify codebase without changing behavior

[bonustrack]

Summary

• Mechanical, behavior-preserving cleanup across 18 files
• Net change: −43 LOC (91 insertions, 134 deletions)
• No feature or behavior changes; all error messages, validation orderings, and API response shapes preserved

What changed

Dead code

• Removed commented-out isLimitReached function and call in src/writer/vote.ts
• Removed commented start-date check in src/writer/proposal.ts
• Removed redundant || { name: 'any', params: {} } fallback in src/helpers/actions.ts (already covered by jsonParse)

Env var consolidation

• Added BROVIDER_URL and SCORE_API_URL exports to src/helpers/utils.ts
• Replaced inline process.env.* reads across 9 files — process.env now lives only in helpers/utils.ts
• Constants use the same UPPER_CASE casing as existing NETWORK/DEFAULT_NETWORK

Micro-simplifications

• src/helpers/requestDeduplicator.ts: dropped no-op .then/.catch in favor of .finally()
• src/scores.ts: Array.from(Array(pages)).forEach(...) → Array.from({length}, ...); let i = 0; if (i) → .entries() with idx > 0
• src/writer/flag-proposal.ts + src/writer/update-proposal.ts: inlined trivial query/params triplets
• Dropped unused let vp: any = {} initializer; removed Promise.resolve(x) in async returns

Shared helpers

• Moved isAuthorized({ space, address }) to src/helpers/actions.ts and reused in flag-proposal.ts and delete-proposal.ts (kept settings.ts untouched — it checks admins only, switching would allow moderators through)
• Added resolvePrivacy(spacePrivacy, payloadPrivacy) in utils.ts, used by proposal.ts and update-proposal.ts
• Consolidated proposal JSON-field parsing in scores.ts into a field array

Control flow

• src/helpers/moderation.ts: recursive run() → while (true) loop

Test plan

• yarn lint passes
• yarn typecheck passes
• yarn test:unit — pass/fail counts identical to master (43 pass, 51 pre-existing failures, 22 todo)
• yarn test:integration (requires DB — verify before merge)
• yarn test:e2e (requires DB — verify before merge)
• Smoke-test a POST / vote/proposal request in dev

🤖 Generated with Claude Code